Create steps and groups (KAC-93) #610

JakubMatejka · 2022-03-27T08:14:23Z

Víceméně se to dá po těch commitech. V prvních čtyřech je to trochu divočejší, ale potom jsem se už ukáznil. 😃

Validate json tags on steps and groups fix test

fix test

fix

JakubMatejka · 2022-03-30T09:23:54Z

Ten inputs_select se fixovat nemusí, na začátku parse() metody se ta mapa inicializuje (což mi jaksi uniklo 😅)

keboola-as-code/internal/pkg/cli/dialog/inputs_select.go

Lines 50 to 51 in 787063d

    
           func (d *inputsSelectDialog) parse(result string) error { 
        
           	d.objectInputs = make(objectInputsMap)

internal/pkg/template/input/input.go

michaljurecko · 2022-03-30T09:27:02Z

Ten inputs_select se fixovat nemusí, na začátku parse() metody se ta mapa inicializuje (což mi jaksi uniklo sweat_smile)

keboola-as-code/internal/pkg/cli/dialog/inputs_select.go

Lines 50 to 51 in 787063d

func (d *inputsSelectDialog) parse(result string) error {

d.objectInputs = make(objectInputsMap)

Aj mne :) ked sme spolu volali, ... ale aj tak to je zle, nemal by byt definovany v strukture ale iba lokalne (mozno tam bude potrebne upravit este nieco naviac, pozrieme ked bude cas)

internal/pkg/template/input/step.go

pkg/lib/operation/template/local/create/operation.go

internal/pkg/cli/dialog/inputs.go

internal/pkg/cli/dialog/inputs_detail_test.go

internal/pkg/cli/dialog/steps.go

internal/pkg/template/input/step.go

test/cli/template-create/complex/out/my-template/v0/src/inputs.jsonnet

internal/pkg/cli/dialog/steps.go

michaljurecko

Je mi luto, ze to musim este vratit: step ID musi byt unikatne napriec celou definiciou.

JakubMatejka · 2022-03-31T06:06:59Z

A jo, já myslel že jak jsme ty idčka odstranili z jsonnetu, tak už to není potřeba a nedošlo mi že kvůli tomu dialogu je to třeba pořád. 🙈

JakubMatejka · 2022-03-31T06:55:59Z

Tak už 😊 1789eb4

michaljurecko

LGTM 🏁

JakubMatejka force-pushed the jakub-steps branch 3 times, most recently from c4d08c6 to d54467b Compare March 28, 2022 15:19

JakubMatejka added 4 commits March 29, 2022 08:32

Validate json tags on steps and groups

a46f541

Validate json tags on steps and groups fix test

Add inputs to StepsGroups

dd8e707

Read/write steps groups from/to inputs.jsonnet

00557df

fix test

Add map inputs to steps and default step

070c774

JakubMatejka force-pushed the jakub-steps branch from d54467b to 070c774 Compare March 29, 2022 06:49

JakubMatejka added 2 commits March 29, 2022 13:37

Remove group id + lowercase and remove whitespaces from step id samples

a4e64ca

Improve steps prompt default value

db14b84

JakubMatejka force-pushed the jakub-steps branch 3 times, most recently from f8d4ff0 to 9f66909 Compare March 30, 2022 06:06

JakubMatejka added 6 commits March 30, 2022 11:03

Validate there is at least one group with one step

e0e2774

fix

Preview created steps in inputs_detail prompt

adde9d0

fix

Fix inputs.jsonnet in tests

b3a5d1c

Change inputsToSteps map to orderedmap

d308833

Fix tests

80415cd

Fix init of stepsGroups for user prompt

787063d

JakubMatejka force-pushed the jakub-steps branch from 9f66909 to 787063d Compare March 30, 2022 09:20

JakubMatejka marked this pull request as ready for review March 30, 2022 09:21

JakubMatejka commented Mar 30, 2022

View reviewed changes

internal/pkg/template/input/input.go Show resolved Hide resolved

JakubMatejka commented Mar 30, 2022

View reviewed changes

internal/pkg/template/input/step.go Show resolved Hide resolved

JakubMatejka commented Mar 30, 2022

View reviewed changes

internal/pkg/template/input/step.go Show resolved Hide resolved

JakubMatejka requested a review from michaljurecko March 30, 2022 09:31

michaljurecko reviewed Mar 30, 2022

View reviewed changes

JakubMatejka added 2 commits March 30, 2022 13:15

Fix passing StepsGroups slice as reference

98bf83c

Review fixes

06e5ff5

Store step ids used in inputs_detail in a map

3c2a8eb

JakubMatejka force-pushed the jakub-steps branch from 03f413d to 3c2a8eb Compare March 30, 2022 14:23

Fix init step with no inputs

1b6c855

JakubMatejka force-pushed the jakub-steps branch from 5d6bb41 to 1b6c855 Compare March 30, 2022 15:01

JakubMatejka requested a review from michaljurecko March 30, 2022 15:10

michaljurecko reviewed Mar 31, 2022

View reviewed changes

Ensure that step has a unique id in the dialog

1789eb4

JakubMatejka force-pushed the jakub-steps branch from f535c23 to 1789eb4 Compare March 31, 2022 06:55

JakubMatejka requested a review from michaljurecko March 31, 2022 07:00

michaljurecko approved these changes Mar 31, 2022

View reviewed changes

JakubMatejka merged commit 020e0d8 into main Mar 31, 2022

JakubMatejka deleted the jakub-steps branch March 31, 2022 07:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create steps and groups (KAC-93) #610

Create steps and groups (KAC-93) #610

JakubMatejka commented Mar 27, 2022 •

edited

Loading

JakubMatejka commented Mar 30, 2022

michaljurecko commented Mar 30, 2022

michaljurecko left a comment

JakubMatejka commented Mar 31, 2022

JakubMatejka commented Mar 31, 2022

michaljurecko left a comment

Create steps and groups (KAC-93) #610

Create steps and groups (KAC-93) #610

Conversation

JakubMatejka commented Mar 27, 2022 • edited Loading

JakubMatejka commented Mar 30, 2022

michaljurecko commented Mar 30, 2022

michaljurecko left a comment

Choose a reason for hiding this comment

JakubMatejka commented Mar 31, 2022

JakubMatejka commented Mar 31, 2022

michaljurecko left a comment

Choose a reason for hiding this comment

JakubMatejka commented Mar 27, 2022 •

edited

Loading